Skip to content

Session Publish Review re-org#9324

Merged
dartajax merged 9 commits into
ilios:masterfrom
michaelchadwick:frontend-7030-session-publish-review-display-upgrade
Jun 5, 2026
Merged

Session Publish Review re-org#9324
dartajax merged 9 commits into
ilios:masterfrom
michaelchadwick:frontend-7030-session-publish-review-display-upgrade

Conversation

@michaelchadwick

@michaelchadwick michaelchadwick commented May 12, 2026

Copy link
Copy Markdown
Contributor

@netlify

netlify Bot commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit c3e8147
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6a219e2475fa230008202ef4
😎 Deploy Preview https://deploy-preview-9324--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Visual Diff Approved

❌ Visual Diff Report — FAILED

884 images compared: 26 different · 858 identical

Details

Differences (26)

File Diff % Notes
desktop-Acceptance _ Program Year - Terms _ list terms _ .png 0.04%
desktop-Acceptance _ Program Year - Terms _ manage terms _ .png 0.03%
desktop-Integration _ Component _ courses_loading _ it renders _ .png 100.00% ⚠️ Dimension mismatch (2844x1000 → 3129x1000)
laptop-Acceptance _ Program Year - Course associations _ course associations are expanded if URL contains corresponding parameter _ .png 0.04%
laptop-Acceptance _ Program Year - Course associations _ expand and collapse course associations _ .png 0.04%
laptop-Acceptance _ Program Year - Objectives _ list editable _ .png 0.03%
laptop-Acceptance _ Program Year - Objectives _ list not editable _ .png 0.03%
laptop-Integration _ Component _ courses_loading _ it renders _ .png 100.00% ⚠️ Dimension mismatch (2727x1000 → 2857x1000)
phone-Acceptance _ Program Year - Cohort members _ cohort members are expanded if URL contains corresponding parameter _ .png 0.08%
phone-Acceptance _ Program Year - Cohort members _ expand and collapse cohort members _ .png 0.09%
phone-Acceptance _ Program Year - Competencies _ list _ .png 0.08%
phone-Acceptance _ Program Year - Competencies _ list with permission to edit _ .png 0.08%
phone-Acceptance _ Program Year - Course associations _ course associations are expanded if URL contains corresponding parameter _ .png 0.09%
phone-Acceptance _ Program Year - Course associations _ expand and collapse course associations _ .png 0.10%
phone-Acceptance _ Program Year - Leadership _ collapsed leadership _ .png 0.09%
phone-Acceptance _ Program Year - Leadership _ list leadership _ .png 0.08%
phone-Acceptance _ Program Year - Objective Vocabulary Terms _ manage and save terms _ .png 0.08%
phone-Acceptance _ Program Year - Terms _ list terms _ .png 0.08%
phone-Acceptance _ Program Year - Terms _ manage terms _ .png 0.08%
phone-Integration _ Component _ courses_loading _ it renders _ .png 100.00% ⚠️ Dimension mismatch (703x1000 → 764x1000)
tablet-Acceptance _ Program Year - Course associations _ course associations are expanded if URL contains corresponding parameter _ .png 0.06%
tablet-Acceptance _ Program Year - Course associations _ expand and collapse course associations _ .png 0.06%
tablet-Acceptance _ Program Year - Leadership _ collapsed leadership _ .png 0.06%
tablet-Acceptance _ Program Year - Leadership _ list leadership _ .png 0.06%
tablet-Acceptance _ Program Year - Terms _ list terms _ .png 0.06%
… and 1 more

Download the results.

@michaelchadwick michaelchadwick force-pushed the frontend-7030-session-publish-review-display-upgrade branch 3 times, most recently from ff0453e to fec1015 Compare June 2, 2026 17:06
@michaelchadwick michaelchadwick marked this pull request as ready for review June 3, 2026 15:57
@michaelchadwick michaelchadwick force-pushed the frontend-7030-session-publish-review-display-upgrade branch from a8c8cde to c3e8147 Compare June 4, 2026 15:47
stopfstedt
stopfstedt approved these changes Jun 4, 2026
View reviewed changes

@stopfstedt stopfstedt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dartajax
dartajax approved these changes Jun 4, 2026
View reviewed changes

@dartajax dartajax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff

@dartajax dartajax added the approve visual diff Manually Approve the Results of a Visual Diff Run label Jun 4, 2026
@dartajax dartajax enabled auto-merge June 5, 2026 00:07
@dartajax dartajax merged commit 2046a4e into ilios:master Jun 5, 2026
97 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stopfstedt stopfstedt stopfstedt approved these changes

@dartajax dartajax dartajax approved these changes

@jrjohnson jrjohnson Awaiting requested review from jrjohnson jrjohnson is a code owner

Assignees

@dartajax dartajax

Labels

approve visual diff Manually Approve the Results of a Visual Diff Run

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ideas About Publish All Display Areas

3 participants

@michaelchadwick @stopfstedt @dartajax